Avoid map key conflict for document results #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently can't have VerticalResults for document verticals since two results from the same entity will cause a map key conflict. To resolve this, we are making the key the result ID and the result index which should always be unique. J=WAT-4282 TEST=manual,auto Created a test document search config on the test-site which previously failed to return VerticalResults properly due to the key error now returns the results and updates on a new search
|
Current unit coverage is 92.12481426448737% |
Fondryext
approved these changes
Aug 12, 2024
Merged
sahilvaidya
added a commit
that referenced
this pull request
Aug 12, 2024
Version 1.6.2 **Fixes** - Enables Document Verticals to use VerticalResult by adjusting VerticalResult map key to combine the result id and index avoiding conflicts #456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently can't have VerticalResults for document verticals since two results from the same entity will cause a map key conflict. To resolve this, we are making the key the result ID and the result index which should always be unique.
J=WAT-4282
TEST=manual,auto
Created a test document search config on the test-site which previously failed to return VerticalResults properly due to the key error now returns the results and updates on a new search